fix: correct ELLIPSE marker size to match in-game display#117
Merged
Conversation
ELLIPSE markers were rendered larger than in-game due to incorrect size calculation using an arbitrary 0.015 constant. Changes: - Calculate ellipse perimeter points in Arma coordinates (meters) - Convert points to latLng using existing armaToLatLng function - Render as L.polygon instead of L.circle for proper ellipse support - Use both size[0] (X radius) and size[1] (Y radius) for true ellipses - Apply rotation using existing _rotatePoints method This aligns ELLIPSE rendering with RECTANGLE, which already correctly converts Arma coordinates to map coordinates.
- Include ELLIPSE shape in updateRender method (was only RECTANGLE) - Add defensive checks for this._size array access to prevent silent errors when size data is malformed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
ELLIPSE markers used an arbitrary calculation:
This magic number
0.015didn't correctly convert Arma meters to Leaflet map units, resulting in markers appearing larger than in-game.Additionally, only
size[0]was used, making all ellipses circular regardless of their actual dimensions.Solution
Changed ELLIPSE to use the same approach as RECTANGLE:
armaToLatLng()_rotatePoints()methodL.polygoninstead ofL.circleThis ensures ellipses:
Test plan